Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuButton changes and additions #1602

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Feb 28, 2024

This PR fixes #1593 and #1594 by:

  • adding a FluentOverlay so clicking outside the menu closes it
  • Adding a ButtonAppearance parameter to make changing the button appearance possible

An example has been added to the deom to show this.
Example of the ovverlay:
issue-#1594

Also, source comments have been added and a documentation section is added to the menu button page.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vnbaaij vnbaaij requested a review from dvoituron February 28, 2024 10:37
@vnbaaij vnbaaij linked an issue Feb 28, 2024 that may be closed by this pull request
@vnbaaij vnbaaij added this to the V4.5.0 milestone Feb 28, 2024
@vnbaaij vnbaaij enabled auto-merge (squash) February 28, 2024 10:38
@Rocky-25
Copy link

This looks good, just wondering if the icon colour should be Accent if it's not an accent button?
FluentMenuButton.razor.cs line 66
_iconColor = ButtonAppearance == Appearance.Accent ? Color.Fill : Color.FillInverse;
should be:
_iconColor = ButtonAppearance == Appearance.Accent ? Color.Fill : Color.Accent;

Icons in a button seem to use this colour?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Feb 28, 2024

No, in this case it is not really used as an icon but more as a text element (which happens to be rendered with an icon) so same color as text

@Rocky-25
Copy link

Okay that's fair enough. Thanks for making the changes Vincent.

@vnbaaij vnbaaij merged commit 686239b into dev Feb 28, 2024
4 checks passed
@vnbaaij vnbaaij deleted the users/vnbaaij/menubutton-issues branch February 28, 2024 12:44
vnbaaij added a commit that referenced this pull request Mar 6, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Fix #1593 and #1594

* Add documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu Button clicking away once menu open Menu Button: Appearance Parameter
3 participants