fix: add 'required' binding to the autocomplete label #1543
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
The Required property from the FluentAutoComplete was not passed on to its label, making it not look required.
a small fix, that took a full 2min to fix :p
🎫 Issues
autocomplete didn't look like it was required, while it was set
👩💻 Reviewer Notes
didn't find any tests to test this with, does autocomplete have any tests/html it compares to that i might have missed?
📑 Test Plan
I added Required to the storyboard's country autocomplete and got a nice '*' to indicate required now
✅ Checklist
General
Component-specific
⏭ Next Steps
none required :)