Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add 'required' binding to the autocomplete label #1543

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

joriverm
Copy link
Contributor

Pull Request

📖 Description

The Required property from the FluentAutoComplete was not passed on to its label, making it not look required.
a small fix, that took a full 2min to fix :p

🎫 Issues

image
autocomplete didn't look like it was required, while it was set

👩‍💻 Reviewer Notes

didn't find any tests to test this with, does autocomplete have any tests/html it compares to that i might have missed?

📑 Test Plan

I added Required to the storyboard's country autocomplete and got a nice '*' to indicate required now

image

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validate Unit Tests for an existing component

⏭ Next Steps

none required :)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@joriverm joriverm changed the title fix: add required binding to the autocomplete label fix: add 'required' binding to the autocomplete label Feb 20, 2024
@vnbaaij vnbaaij merged commit 222bd32 into microsoft:dev Feb 20, 2024
2 checks passed
@joriverm joriverm deleted the fixes/autocomplete_required branch February 27, 2024 10:07
vnbaaij pushed a commit that referenced this pull request Mar 6, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: AI\jvermeyl <joris.vermeylen@uzgent.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants