-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding .NET Aspire's AppBar #1527
Merged
Merged
+924
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesome 🎉. Could you add explanation (comments) for each properties ? What is the goal of the second icon? |
Will do. Second item is mouseover one. |
See my to do note... |
dvoituron
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First part of my reviews
dvoituron
requested changes
Mar 1, 2024
- Add PopoverVisibilityChanged event callback - Add popover show/hide by keyboard
Loading status checks…
…luentui-blazor into users/vnbaaij/appbar
- Rename SecondaryIcon ->IconActive - Add code comments for docs
- Replace some classes with part/role
Loading status checks…
…luentui-blazor into users/vnbaaij/appbar
dvoituron
requested changes
Mar 5, 2024
Loading status checks…
…luentui-blazor into users/vnbaaij/appbar
dvoituron
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an AppBar component (coming from .NET Aspire) like you know and love from Teams.
To do:
ImplementFluentOverflow
(...) with 'view more apps' functionality.