Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .NET Aspire's AppBar #1527

Merged
merged 19 commits into from
Mar 5, 2024
Merged

Adding .NET Aspire's AppBar #1527

merged 19 commits into from
Mar 5, 2024

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Feb 16, 2024

Adding an AppBar component (coming from .NET Aspire) like you know and love from Teams.

FluentAppBar 2

To do:

  • Implement FluentOverflow (...) with 'view more apps' functionality.

@dvoituron
Copy link
Collaborator

Awesome 🎉. Could you add explanation (comments) for each properties ?

What is the goal of the second icon?

@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Feb 16, 2024

Will do.

Second item is mouseover one.

@dungio
Copy link

dungio commented Feb 16, 2024

What if i have many items and cannot display all? is show scroll? Is there options to collapse items like vs code?
image

@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Feb 16, 2024

See my to do note...

@vnbaaij vnbaaij marked this pull request as draft February 16, 2024 22:19
@vnbaaij vnbaaij marked this pull request as ready for review February 29, 2024 22:56

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
@vnbaaij vnbaaij enabled auto-merge (squash) February 29, 2024 22:57
@vnbaaij vnbaaij changed the title Initial work for adding Aspire's AppBar Adding .NET Aspire's AppBar Feb 29, 2024
Copy link
Collaborator

@dvoituron dvoituron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part of my reviews

vnbaaij added 10 commits March 1, 2024 14:43

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
- Add PopoverVisibilityChanged event callback
- Add popover show/hide by keyboard

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
…luentui-blazor into users/vnbaaij/appbar

Verified

This commit was signed with the committer’s verified signature.
marco-ippolito Marco Ippolito
- Rename SecondaryIcon ->IconActive
- Add code comments for docs

Verified

This commit was signed with the committer’s verified signature.
marco-ippolito Marco Ippolito
- Replace some classes with part/role
…luentui-blazor into users/vnbaaij/appbar
@vnbaaij vnbaaij requested a review from dvoituron March 4, 2024 21:27
@vnbaaij vnbaaij disabled auto-merge March 4, 2024 21:27
@vnbaaij vnbaaij enabled auto-merge (squash) March 4, 2024 21:27
@vnbaaij vnbaaij merged commit 746ca02 into dev Mar 5, 2024
4 checks passed
@vnbaaij vnbaaij deleted the users/vnbaaij/appbar branch March 5, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants