Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SplitPanels.ts #1520

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Update SplitPanels.ts #1520

merged 1 commit into from
Feb 16, 2024

Conversation

weskroesbergen
Copy link
Contributor

Pull Request

📖 Description

Added handling for browsers that don't support CSSStyleSheet constructor.

https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleSheet/CSSStyleSheet#browser_compatibility

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validate Unit Tests for an existing component

⏭ Next Steps

Sorry, something went wrong.

Added handling for browsers that don't support CSSStyleSheet constructor
@weskroesbergen
Copy link
Contributor Author

@microsoft-github-policy-service agree

@vnbaaij vnbaaij self-assigned this Feb 16, 2024
@vnbaaij vnbaaij added this to the V4.5.0 milestone Feb 16, 2024
Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!

@vnbaaij vnbaaij merged commit 76449f3 into microsoft:dev Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants