Adds FieldIdentifier parameter to FluentValidationMessage #1489
+19
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds a new parameter,
Field
(of typeFieldIdentifier
) to theFluentValidationMessage
component. This allows validation messages to be specified with a direct reference to a field within anEditContext
/EditForm
, rather than only through an accessor.For fields that represent a property on a pre-defined model passed to an
EditContext
, this parameter is extraneous since those model (auto-)properties double as a field accessor. However, for dynamic models that do not have design-time accessors, aFieldIdentifier
is more reliable than an accessor.Example usage
With some additional work, an
EditForm
can work with a dictionary rather than an object model:No input given:
Valid input and invalid (white space) input:
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
No tests affected by this addition. This new property has been tested in a scenario such as above and more complex.
✅ Checklist
General
Component-specific
⏭ Next Steps