Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#4582] UserAssignedIdentity(WorkloadIdentity) auth fails with 'scope https://api.botframework.com is not valid' #4607

Merged
merged 2 commits into from
Jan 24, 2024
Merged

fix: [#4582] UserAssignedIdentity(WorkloadIdentity) auth fails with 'scope https://api.botframework.com is not valid' #4607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d368166
Add scope post-fix in managedIdentityAuthenticator.
ceciliaavila Jan 19, 2024
8a1c544
Fix unit test
ceciliaavila Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions libraries/botframework-connector/src/auth/managedIdentityAuthenticator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ export class ManagedIdentityAuthenticator {
ok(resource?.trim(), 'ManagedIdentityAuthenticator.constructor(): missing resource.');
ok(tokenProviderFactory, 'ManagedIdentityAuthenticator.constructor(): missing tokenProviderFactory.');

const scopePostfix = '/.default';
if (!resource.endsWith(scopePostfix)) {
resource = `${resource}${scopePostfix}`;
}

this.resource = resource;
this.tokenProvider = tokenProviderFactory.createAzureServiceTokenProvider(appId);
}
Expand Down
2 changes: 1 addition & 1 deletion libraries/botframework-connector/tests/auth/managedIdentityAuthenticator.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const sinon = require('sinon');
const { JwtTokenProviderFactory, ManagedIdentityAuthenticator } = require('../../lib');

const testAppId = 'foo';
const testAudience = 'bar';
const testAudience = 'bar/.default';
const authResult = {
token: '123',
expiresOnTimestamp: 3000,
Expand Down