Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add /.default to oAuthScope default value for appCredentials #4585

Closed
wants to merge 2 commits into from
Closed

fix: add /.default to oAuthScope default value for appCredentials #4585

wants to merge 2 commits into from

Conversation

patst
Copy link

@patst patst commented Dec 14, 2023

Fixes #4582

Description

The default constant has the issuer url. The oAuthScope requires to end with /.default.

Specific Changes

  • added /.default to the default oAuthScope value

Testing

we are using this change in our application (patched via patch-package library)

@tracyboehrer
Copy link
Member

@ceciliaavila Can your team review this in light of how this is handled in the other repos? There is some divergence here and very well could need consideration SDK-wide. Python does something similar. DotNet does not appear to. Though the MsalAppCredentials does during refreshToken.

@patst patst changed the title add /.default to oAuthScope default value for appCredentials fix: add /.default to oAuthScope default value for appCredentials Dec 14, 2023
@patst
Copy link
Author

patst commented Dec 14, 2023

@ceciliaavila Can your team review this in light of how this is handled in the other repos? There is some divergence here and very well could need consideration SDK-wide. Python does something similar. DotNet does not appear to. Though the MsalAppCredentials does during refreshToken.

thanks for taking a look at this.

Looking forward to get it resolved this way or another, since the current behaviour is just broken.

I fixed the eslint finding (had trouble getting it to run locally on an arm macbook, yarn install does not seems to work for all the dependencies in the repository )

@ceciliaavila
Copy link
Collaborator

Closing in favor of PR #4607

@patst patst deleted the fix/oauthscope branch January 24, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserAssignedIdentity(WorkloadIdentity) auth fails with 'scope https://api.botframework.com is not valid'
3 participants