Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for SharePoint (Viva) Adaptive Card Extension #4551

Merged
merged 13 commits into from Nov 1, 2023

Conversation

AJIXuMuK
Copy link
Contributor

@AJIXuMuK AJIXuMuK commented Oct 23, 2023

fixes: #4557

Description

SharePoint Framework is adding a new adaptive card experience (ACE) where it is powered by a Bot. In order to be able to implement the bot we are updating the BotBuilder Framework to natively support these API's to make it easier for end users to add a bot powered ACE.

Specific Changes

We support 5 new BotInvoke activities:
"cardExtension/getCardView"
"cardExtension/getQuickView"
"cardExtension/getPropertyPaneConfiguration"
"cardExtension/setPropertyPaneConfiguration"
"cardExtension/handleAction"

The SharePointActivityHandler in botbuilder is the base class for developing a bot powered ACE. Users of this base class will need to implement the following 5 methods:

onSharePointTaskGetCardViewAsync
onSharePointTaskGetQuickViewAsync
onSharePointTaskGetPropertyPaneConfigurationAsync
onSharePointTaskSetPropertyPaneConfigurationAsync
onSharePointTaskHandleActionAsync

Testing

This was tested using a test app.

@coveralls
Copy link

coveralls commented Oct 23, 2023

Pull Request Test Coverage Report for Build 6660259550

  • 72 of 78 (92.31%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.822%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-schema/src/sharepoint/cardView/cardViewParameters.ts 6 12 50.0%
Totals Coverage Status
Change from base Build 6614208601: 0.02%
Covered Lines: 20341
Relevant Lines: 22723

💛 - Coveralls

@AJIXuMuK AJIXuMuK changed the title SP ACE API feat: Support for SharePoint (Viva) Adaptive Card Extension Oct 31, 2023
@AJIXuMuK AJIXuMuK marked this pull request as ready for review October 31, 2023 22:58
@AJIXuMuK AJIXuMuK requested a review from a team as a code owner October 31, 2023 22:58
@tracyboehrer tracyboehrer merged commit d18c19c into microsoft:main Nov 1, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The bot builder framework should support SharePoint bot driven ACEs
4 participants