DrawingIsland: Add package reference to Win2D to make it possible to generate a MSIX and deploy #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseCol
force-pushed
the
user/jecollin/fix-msix
branch
from
bd5a599
to
7f447bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For DrawingIsland, add package reference to Win2D to make it possible to generate a MSIX and deploy. With this change, the Lottie version now works on Server2019.
I've also added the PackageReferences to the wapproj. I'm not entirely sure this is required, but I've been encouraged to do this in the past, so I'm doing it here for good measure.
I also gave the package a more recognizable name so it's easy to find with "get-appxpackage".