Declaration emit should avoid issuing errors on unresolved names #58536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
commented
May 14, 2024
| if (false) { | ||
| export var myClass = 0; | ||
| } | ||
| export type MyClass = typeof myClass; | ||
| ~~~~~~~ | ||
| !!! error TS4081: Exported type alias 'MyClass' has or is using private name 'myClass'. |
There was a problem hiding this comment.
Declaration emit errors are emitted in the presence of parse errors (unlike checker errors), so this (pretty bogus, given the parse error) error was here before, and now it's gone. If checker errors were reported, there would be one on myClass here, but, again, blocked by a parse error anyway.
sheetalkamat
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These already will get errors in the checker when the file is typechecked, so the declaration emitter doesn't need to double up and also error on them.
This basically allows the declaration emitter to copy inputs with unresolvable names into the output without the output being blocked by a declaration-emitter issued error.
Fixes #58496
Fixes #58535