fix: correct mtime for useFsEventsOnParentDirectory events #57877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57792
Problem
On macOS Sonoma,
getModifiedTime(fileOrDirectory)
will return the wrong mtime for file change events inFileSystemEntryKind.Directory
watchers, sincefoo/bar.ts
modification will not bumpfoo/
mtime nor will the event itself specify an mtime. This will cause file modifications to not be picked up when runningtsc --watch --watchFile usefseventsonparentdirectory
.Solution
Change
getModifiedTime(fileOrDirectory)
togetModifiedTime(filename)
, wherefilename
is calculated by passing throughentryKind
.Testing
Provided regression test which fails on
main
. The macOS Sonoma behavior is modeled by the mock filesystem using a new optionmodifyFileWithoutModifyDirectory
.