Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 56087 #57849

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Revert PR 56087 #57849

merged 1 commit into from
Mar 19, 2024

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Mar 19, 2024

This reverts #56087. That PR was a fix for a bug present in all versions of TS, but caused 2 more bugs and a perf regression in 5.4. It may be the case that #57396 fixes all of these, but that PR introduces a lot more code and is still in discussion,

Fixes #57843
Fixes #57781
Fixes #57357
Reopens #49171

Not sure if I'm reading the baselines correctly, but since this is removing the perf baseline, I guess the new baselines would have caught this regression as before the revert, there are some 3.2k types, but after, it's under the 100 type threshold? And similarly for symbols.

@jakebailey
Copy link
Member Author

FWIW this will likely not cherry-pick without manual intervention because of the baseline change.

@jakebailey
Copy link
Member Author

Sent #57850 for 5.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
4 participants