Fixed a regression related to determining argument index when spread elements are involved #57637
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,201 @@ | ||
| // === SignatureHelp === | ||
| === /tests/cases/fourslash/index.js === | ||
| // const promisify = function (thisArg, fnName) { | ||
| // const fn = thisArg[fnName]; | ||
| // return function () { | ||
| // return new Promise((resolve) => { | ||
| // fn.call(thisArg, ...arguments, ); | ||
| // ^ | ||
| // | ---------------------------------------------------------------------- | ||
| // | Function.call(thisArg: any, **...argArray: any[]**): any | ||
| // | Calls a method of an object, substituting another object for the current object. | ||
| // | @param thisArg The object to be used as the current object. | ||
| // | @param argArray A list of arguments to be passed to the method. | ||
| // | ---------------------------------------------------------------------- | ||
| // }); | ||
| // }; | ||
| // }; | ||
|
|
||
| [ | ||
| { | ||
| "marker": { | ||
| "fileName": "/tests/cases/fourslash/index.js", | ||
| "position": 189, | ||
| "name": "1" | ||
| }, | ||
| "item": { | ||
| "items": [ | ||
| { | ||
| "isVariadic": true, | ||
| "prefixDisplayParts": [ | ||
| { | ||
| "text": "Function", | ||
| "kind": "localName" | ||
| }, | ||
| { | ||
| "text": ".", | ||
| "kind": "punctuation" | ||
| }, | ||
| { | ||
| "text": "call", | ||
| "kind": "methodName" | ||
| }, | ||
| { | ||
| "text": "(", | ||
| "kind": "punctuation" | ||
| } | ||
| ], | ||
| "suffixDisplayParts": [ | ||
| { | ||
| "text": ")", | ||
| "kind": "punctuation" | ||
| }, | ||
| { | ||
| "text": ":", | ||
| "kind": "punctuation" | ||
| }, | ||
| { | ||
| "text": " ", | ||
| "kind": "space" | ||
| }, | ||
| { | ||
| "text": "any", | ||
| "kind": "keyword" | ||
| } | ||
| ], | ||
| "separatorDisplayParts": [ | ||
| { | ||
| "text": ",", | ||
| "kind": "punctuation" | ||
| }, | ||
| { | ||
| "text": " ", | ||
| "kind": "space" | ||
| } | ||
| ], | ||
| "parameters": [ | ||
| { | ||
| "name": "thisArg", | ||
| "documentation": [ | ||
| { | ||
| "text": "The object to be used as the current object.", | ||
| "kind": "text" | ||
| } | ||
| ], | ||
| "displayParts": [ | ||
| { | ||
| "text": "thisArg", | ||
| "kind": "parameterName" | ||
| }, | ||
| { | ||
| "text": ":", | ||
| "kind": "punctuation" | ||
| }, | ||
| { | ||
| "text": " ", | ||
| "kind": "space" | ||
| }, | ||
| { | ||
| "text": "any", | ||
| "kind": "keyword" | ||
| } | ||
| ], | ||
| "isOptional": false, | ||
| "isRest": false | ||
| }, | ||
| { | ||
| "name": "argArray", | ||
| "documentation": [ | ||
| { | ||
| "text": "A list of arguments to be passed to the method.", | ||
| "kind": "text" | ||
| } | ||
| ], | ||
| "displayParts": [ | ||
| { | ||
| "text": "...", | ||
| "kind": "punctuation" | ||
| }, | ||
| { | ||
| "text": "argArray", | ||
| "kind": "parameterName" | ||
| }, | ||
| { | ||
| "text": ":", | ||
| "kind": "punctuation" | ||
| }, | ||
| { | ||
| "text": " ", | ||
| "kind": "space" | ||
| }, | ||
| { | ||
| "text": "any", | ||
| "kind": "keyword" | ||
| }, | ||
| { | ||
| "text": "[", | ||
| "kind": "punctuation" | ||
| }, | ||
| { | ||
| "text": "]", | ||
| "kind": "punctuation" | ||
| } | ||
| ], | ||
| "isOptional": false, | ||
| "isRest": false | ||
| } | ||
| ], | ||
| "documentation": [ | ||
| { | ||
| "text": "Calls a method of an object, substituting another object for the current object.", | ||
| "kind": "text" | ||
| } | ||
| ], | ||
| "tags": [ | ||
| { | ||
| "name": "param", | ||
| "text": [ | ||
| { | ||
| "text": "thisArg", | ||
| "kind": "parameterName" | ||
| }, | ||
| { | ||
| "text": " ", | ||
| "kind": "space" | ||
| }, | ||
| { | ||
| "text": "The object to be used as the current object.", | ||
| "kind": "text" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "param", | ||
| "text": [ | ||
| { | ||
| "text": "argArray", | ||
| "kind": "parameterName" | ||
| }, | ||
| { | ||
| "text": " ", | ||
| "kind": "space" | ||
| }, | ||
| { | ||
| "text": "A list of arguments to be passed to the method.", | ||
| "kind": "text" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "applicableSpan": { | ||
| "start": 166, | ||
| "length": 23 | ||
| }, | ||
| "selectedItemIndex": 0, | ||
| "argumentIndex": 1, | ||
| "argumentCount": 2 | ||
| } | ||
| } | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this part of the comment because I adjusted the behavior (see
tests/cases/fourslash/signatureHelpSkippedArgs1.ts). I find the new behavior better and it was easier for me to rewrite those loops while accommodating for that test case.