Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpile jsdoc parsing mode #56627

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Transpile jsdoc parsing mode #56627

merged 3 commits into from
Dec 1, 2023

Conversation

sheetalkamat
Copy link
Member

Fixes #56625

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 1, 2023
@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@jakebailey
Copy link
Member

I will be interested in a test for this; my impression was that this flag did not affect emit at all, and #56625 did not mention transformers in the original report.

@andrewbranch
Copy link
Member

@typescript-bot cherry-pick this to release-5.3

@typescript-bot
Copy link
Collaborator

Heya @andrewbranch, I've started to cherry-pick this into release-5.3 for you. Here's the link to my best guess at the log.

@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I've created #56629 for you.

@sheetalkamat sheetalkamat merged commit 5bc6617 into main Dec 1, 2023
19 checks passed
@sheetalkamat sheetalkamat deleted the transpileJSDoc branch December 1, 2023 01:21
DanielRosenwasser added a commit that referenced this pull request Dec 2, 2023
)

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make JSDoc Parsing Configurable using the transpileModule method
4 participants