Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare typingsInstaller as optional for ProjectService #53896

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

jakebailey
Copy link
Member

Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you makr it optional in SessionOptions too ?

@jakebailey
Copy link
Member Author

Done, though that required a code change.

@jakebailey jakebailey merged commit 5402998 into microsoft:main Apr 18, 2023
19 checks passed
@jakebailey jakebailey deleted the optional-typingsInstaller branch April 18, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow not providing typingInstaller to tsserver ProjectService
2 participants