Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Pick PR #53613 (Fix Go To Source Definition in `--m...) into release-5.0 #53617

Merged

Conversation

typescript-bot
Copy link
Collaborator

This cherry-pick was triggered by a request on #53613
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.

cc @andrewbranch

Component commits:
449b6e6 Fix Go To Source Definition in --moduleResolution bundler

1fddb2a Accept baseline

8c81daf Actually fix it

e8f7120 Remove unnecessary function calls

47ae29a Fix bad edits

4dd8655 Fix lint

2d362be Fix lint

aa4e912 Fix lint
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 31, 2023
@andrewbranch andrewbranch added this to the TypeScript 5.0.4 milestone Mar 31, 2023
@DanielRosenwasser
Copy link
Member

@andrewbranch any idea why CI is failing?

@andrewbranch
Copy link
Member

Hummm we might need to pull #52576 into the release branch

@andrewbranch
Copy link
Member

There are conflicts in the cherry-pick. I’m just going to try to fix up the test here.

@DanielRosenwasser DanielRosenwasser merged commit 365cb58 into microsoft:release-5.0 Apr 5, 2023
18 checks passed
drivron pushed a commit to scenari/typescript that referenced this pull request Sep 14, 2023
…to release-5.0 (microsoft#53617)

Co-authored-by: Andrew Branch <andrew@wheream.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants