Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow not providing typingInstaller to tsserver ProjectService #53803

Closed
5 tasks done
JoshuaKGoldberg opened this issue Apr 16, 2023 · 0 comments Β· Fixed by #53896
Closed
5 tasks done

Allow not providing typingInstaller to tsserver ProjectService #53803

JoshuaKGoldberg opened this issue Apr 16, 2023 · 0 comments Β· Fixed by #53896
Assignees
Labels
Needs Investigation This issue needs a team member to investigate its status.

Comments

@JoshuaKGoldberg
Copy link
Contributor

Suggestion

πŸ” Search Terms

typingInstaller tsserver ProjectService

βœ… Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Porting @sheetalkamat's comment from https://github.com/typescript-eslint/typescript-eslint/pull/6754/files#r1161949194:

Even though API doesnt say so you can pass typingInstaller as undefined. We probably need to update the API on our side to reflect that.

πŸ“ƒ Motivating Example

typescript-eslint/typescript-eslint#6754

πŸ’» Use Cases

In https://github.com/typescript-eslint/typescript-eslint/pull/6754/files#diff-48a0545adecca3dfc410b60a48d9665bca5d6124695f462ba16905ec23a9d722R45 I provided an object with empty functions, etc. - but undefined apparently should work too? That'd be much more convenient (& less confusing) on our end as an implementer, trying to instantiate a new project service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants