We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typingInstaller tsserver ProjectService
My suggestion meets these guidelines:
Porting @sheetalkamat's comment from https://github.com/typescript-eslint/typescript-eslint/pull/6754/files#r1161949194:
Even though API doesnt say so you can pass typingInstaller as undefined. We probably need to update the API on our side to reflect that.
typescript-eslint/typescript-eslint#6754
In https://github.com/typescript-eslint/typescript-eslint/pull/6754/files#diff-48a0545adecca3dfc410b60a48d9665bca5d6124695f462ba16905ec23a9d722R45 I provided an object with empty functions, etc. - but undefined apparently should work too? That'd be much more convenient (& less confusing) on our end as an implementer, trying to instantiate a new project service.
undefined
The text was updated successfully, but these errors were encountered:
jakebailey
Successfully merging a pull request may close this issue.
Suggestion
π Search Terms
typingInstaller tsserver ProjectService
β Viability Checklist
My suggestion meets these guidelines:
β Suggestion
Porting @sheetalkamat's comment from https://github.com/typescript-eslint/typescript-eslint/pull/6754/files#r1161949194:
π Motivating Example
typescript-eslint/typescript-eslint#6754
π» Use Cases
In https://github.com/typescript-eslint/typescript-eslint/pull/6754/files#diff-48a0545adecca3dfc410b60a48d9665bca5d6124695f462ba16905ec23a9d722R45 I provided an object with empty functions, etc. - but
undefined
apparently should work too? That'd be much more convenient (& less confusing) on our end as an implementer, trying to instantiate a new project service.The text was updated successfully, but these errors were encountered: