Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Build Fix #456

Merged
merged 2 commits into from Jan 22, 2024
Merged

XS✔ ◾ Build Fix #456

merged 2 commits into from Jan 22, 2024

Conversation

muiriswoulfe
Copy link
Member

Summary

Motivation

Following recent changes to https://json.schemastore.org/package.json, the main build loop started to fail.

Technical

Updating the contents of the package.json file to downgrade the JSON schema to a supported version, as per the previous iteration of the file.

This change also adds workflow_dispatch to the build workflow, to allow it to be run manually if required for testing.

Testing

Test Types

  • Unit tests
  • Manual tests

Unit Test Coverage

100%

@muiriswoulfe muiriswoulfe added the bug Something isn't working label Jan 22, 2024
@muiriswoulfe muiriswoulfe self-assigned this Jan 22, 2024
@muiriswoulfe muiriswoulfe requested a review from a team as a code owner January 22, 2024 10:54
Copy link
Contributor

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 2
Total 2

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Build Fix XS✔ ◾ Build Fix Jan 22, 2024
@muiriswoulfe muiriswoulfe enabled auto-merge (squash) January 22, 2024 11:57
@muiriswoulfe muiriswoulfe merged commit ec0e791 into main Jan 22, 2024
18 checks passed
@muiriswoulfe muiriswoulfe deleted the muiriswoulfe/build-fix branch January 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants