Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Pipeline Compliance: Updating CredScan #440

Merged
merged 1 commit into from Nov 2, 2023

Conversation

muiriswoulfe
Copy link
Member

@muiriswoulfe muiriswoulfe commented Nov 2, 2023

Summary

Motivation

Proactively updating CredScan settings to ignore the minified JSON files and ensure only actual credentials are flagged.

Technical

Adding a new CredScan suppressions file with the appropriate modification and explanation.

Testing

Test Types

  • Unit tests
  • Manual tests

@muiriswoulfe muiriswoulfe added the bug Something isn't working label Nov 2, 2023
@muiriswoulfe muiriswoulfe self-assigned this Nov 2, 2023
@muiriswoulfe muiriswoulfe requested a review from a team as a code owner November 2, 2023 10:40
Copy link
Contributor

github-actions bot commented Nov 2, 2023

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 0
Test Code 0
Subtotal 0
Ignored Code 13
Total 13

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Pipeline Compliance: Adding CredScan Suppression XS✔ ◾ Pipeline Compliance: Adding CredScan Suppression Nov 2, 2023
@muiriswoulfe muiriswoulfe enabled auto-merge (squash) November 2, 2023 11:13
@muiriswoulfe muiriswoulfe merged commit 6f35577 into main Nov 2, 2023
17 checks passed
@muiriswoulfe muiriswoulfe deleted the muiriswoulfe/pipeline-compliance-credscan branch November 2, 2023 11:25
@muiriswoulfe muiriswoulfe changed the title XS✔ ◾ Pipeline Compliance: Adding CredScan Suppression XS✔ ◾ Pipeline Compliance: Updating CredScan Nov 2, 2023
@muiriswoulfe muiriswoulfe added enhancement New feature or request and removed bug Something isn't working labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants