Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync RunVSTestTask task params #540

Merged
merged 1 commit into from Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions azure-pipelines-official.yml
Expand Up @@ -21,6 +21,7 @@ trigger:
paths:
exclude:
- '*.md'
pr: none
extends:
template: azure-pipelines/MicroBuild.1ES.Official.yml@MicroBuildTemplate
parameters:
Expand Down
24 changes: 0 additions & 24 deletions src/RunTests/RunVSTestTask.cs
Expand Up @@ -15,11 +15,6 @@ public class RunVSTestTask : ToolTask
private static readonly HashSet<string> NormalTestLogging = new (new[] { "n", "normal", "d", "detailed", "diag", "diagnostic" }, StringComparer.OrdinalIgnoreCase);
private static readonly HashSet<string> QuietTestLogging = new (new[] { "q", "quiet" }, StringComparer.OrdinalIgnoreCase);

/// <summary>
/// Gets or Sets Full path to the test file.
/// </summary>
public string IsTestProject { get; set; }

/// <summary>
/// Gets or Sets Full path to the test file.
/// </summary>
Expand Down Expand Up @@ -65,19 +60,6 @@ public class RunVSTestTask : ToolTask
/// </summary>
public string VSTestDiag { get; set; }

/// <summary>
/// Gets or Sets Command line options for VSTest.
/// </summary>
public string[] VSTestCLIRunSettings { get; set; }

// Initialized to empty string to allow declaring as non-nullable, the property is marked as
// required so we can ensure that the property is set to non-null before the task is executed.

/// <summary>
/// Gets or Sets Path to VSTest console executable.
/// </summary>
public string VSTestConsolePath { get; set; } = string.Empty;

/// <summary>
/// Gets or Sets Directory where VSTest results are saved.
/// </summary>
Expand Down Expand Up @@ -148,12 +130,6 @@ public class RunVSTestTask : ToolTask
/// </summary>
public string VSTestSessionCorrelationId { get; set; }

/// <summary>
/// Gets or Sets Runner version of VSTest.
/// </summary>
[Required]
public string VSTestRunnerVersion { get; set; }

protected override string ToolName => "vstest.console.exe";

protected override MessageImportance StandardOutputLoggingImportance => MessageImportance.High;
Expand Down
4 changes: 3 additions & 1 deletion src/RunTests/build/Microsoft.Build.RunVSTest.targets
Expand Up @@ -8,14 +8,15 @@
<UsingTask TaskName="Microsoft.Build.RunVSTestTask" AssemblyFile="$(MSBuildThisFileDirectory)netstandard2.0\Microsoft.Build.RunVSTest.dll" Condition="'$(MSBuildRuntime)' != 'Core'"/>
<Target Name="RunVSTest" AfterTargets="Test" Condition="'$(MSBuildRuntime)' != 'Core'">
<RunVSTestTask
VSTestRunnerVersion="$(VSTestRunnerVersion)"
TestFileFullPath="$(TargetPath)"
VSTestSetting="$(VSTestSetting)"
VSTestTestAdapterPath="$(VSTestTestAdapterPath)"
VSTestFramework="$(VSTestFramework)"
VSTestPlatform="$(VSTestPlatform)"
VSTestTestCaseFilter="$(VSTestTestCaseFilter)"
VSTestLogger="$(VSTestLogger)"
VSTestListTests="$(VSTestListTests)"
VSTestDiag="$(VSTestDiag)"
VSTestResultsDirectory="$(VSTestResultsDirectory)"
VSTestVerbosity="$(VSTestVerbosity)"
VSTestCollect="$(VSTestCollect)"
Expand All @@ -25,6 +26,7 @@
VSTestBlameCrashCollectAlways="$(VSTestBlameCrashCollectAlways)"
VSTestBlameHang="$(VSTestBlameHang)"
VSTestBlameHangDumpType="$(VSTestBlameHangDumpType)"
VSTestBlameHangTimeout="$(VSTestBlameHangTimeout)"
VSTestTraceDataCollectorDirectoryPath="$(VSTestTraceDataCollectorDirectoryPath)"
VSTestNoLogo="$(VSTestNoLogo)"
VSTestArtifactsProcessingMode="$(VSTestArtifactsProcessingMode)"
Expand Down