Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint against supported TS versions not just shipped #679

Merged
merged 1 commit into from May 22, 2023

Commits on May 20, 2023

  1. Lint against supported TS versions not just shipped

    Fixes
    ```AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    
      assert(minIdx >= 0)
    
        at range (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/@definitelytyped/dtslint-runner/node_modules/@definitelytyped/dtslint/src/lint.ts:261:3)
        at getLintConfig (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/@definitelytyped/dtslint-runner/node_modules/@definitelytyped/dtslint/src/lint.ts:239:28)
        at lint (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/@definitelytyped/dtslint-runner/node_modules/@definitelytyped/dtslint/src/lint.ts:40:18)
        at testTypesVersion (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/@definitelytyped/dtslint-runner/node_modules/@definitelytyped/dtslint/src/index.ts:233:15)
        at runTests (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/@definitelytyped/dtslint-runner/node_modules/@definitelytyped/dtslint/src/index.ts:197:7)
    Error: Process completed with exit code 1.
    ```
    -- DefinitelyTyped/DefinitelyTyped/actions/runs/5030923969/jobs/9023668157?pr=65135#step:6:1920
    
    Only verified these changes locally with `npm run test react`.
    eps1lon committed May 20, 2023
    Configuration menu
    Copy the full SHA
    b017dca View commit details
    Browse the repository at this point in the history