Remove applicationinsights #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on an analysis of azure usage with @RyanCavanaugh. This hasn't worked for a long time, because there's a bug in the publish notification code that runs before the logging. I'm not sure whether to delete that or to fix it. Publication has been reliable (and predictable!--since the Functions changeover) for a long time so neither the stats nor the notification are as necessary as they once were.
jakebailey
approved these changes
May 10, 2023
|
Note to self: after I merge and ship this, I need to remove APPINSIGHTS_INSTRUMENTATIONKEY from Azure as well. (it silently fails to log without it, and we're already not logging successfully, so actually I guess it's OK to delete it whenever) |
|
This is how we see logs when the publisher crashes. This was definitely working and useful fairly recently. |
|
Oh :( |
|
To clarify, I don’t think we were using the events, but I believe the setup/start calls are necessary in order to see stdout/stderr in the Azure portal. |
|
All right, I'll revert it tomorrow and then remove only the event logging. |
sandersn
added a commit
to sandersn/DefinitelyTyped-tools
that referenced
this pull request
May 11, 2023
This reverts commit 46828d6.
sandersn
added a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on an analysis of azure usage with @RyanCavanaugh.
This hasn't worked for a long time, because there's a bug in the publish notification code that runs before the call to application insights. I'm not sure whether to delete that or to fix it. Publication has been reliable (and predictable!--since the Functions changeover) for a long time so neither the notification nor the stats are as necessary as they once were.