Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add googleapis to allowed dependencies #667

Merged
merged 1 commit into from Apr 26, 2023
Merged

Add googleapis to allowed dependencies #667

merged 1 commit into from Apr 26, 2023

Conversation

KonradPerlicki
Copy link
Contributor

jakebailey
jakebailey requested changes Apr 26, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er, aren't all Google APIs already covered by the gapi packages?

@KonradPerlicki
Copy link
Contributor Author

You're right, I have replaced the package, thanks and I'm closing PR

@jakebailey
Copy link
Member

On second look, I don't know that the gapi packages are the right ones because of their global behavior, actually...

@jakebailey
Copy link
Member

But maybe googleapis does that too. Not really sure what the difference is between them.

@KonradPerlicki
Copy link
Contributor Author

The original package uses googleapis so It was my first thought to use it as well

@jakebailey
Copy link
Member

Ah, then that settles that. 127MB package, though, wow!

@KonradPerlicki
Copy link
Contributor Author

So, will you accept that and should I revert my last changes from previous or what now?

@jakebailey
Copy link
Member

Yes, given the npm package depends on googleapis.

@jakebailey jakebailey merged commit 91e2462 into microsoft:master Apr 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KonradPerlicki @jakebailey