Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @react-native/virtualized-lists to allowed deps #666

Merged

Conversation

lunaleaps
Copy link
Contributor

@lunaleaps lunaleaps commented Apr 25, 2023

Adding @react-native/virtualized-lists to allowed dependencies as React Native 0.72 typings depend on it.

Adding this here because of the error running yarn test-all in DefinitelyTyped

Error: In package.json: Dependency @react-native/virtualized-lists not in the allowed dependencies list.
If you are depending on another `@types` package, do *not* add it to a `package.json`. Path mapping should make the import work.
For namespaced dependencies you then have to add a `paths` mapping from `@namespace/*` to `namespace__*` in `tsconfig.json`.
If this is an external library that provides typings,  please make a pull request to microsoft/DefinitelyTyped-tools adding it to `packages/definitions-parser/allowedPackageJsonDependencies.txt`.

This is the active branch of releasing React Native 0.72 types: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/65282/files#diff-2d08ee5e33d7446c67ab29224efa740bfde978bfb9f0109e061e87f7ff7af6dbR4

@andrewbranch andrewbranch merged commit 357c10a into microsoft:master Apr 25, 2023
1 check passed
@lunaleaps lunaleaps deleted the add-react-native-virtualized-lists branch April 25, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants