[BUG] Excessive memory usage for SPA where unload hooks keep accumulating #2311 #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
Mar 20, 2024
MSNev
commented
- Rework Asynchronous notification handling
MSNev
commented
Mar 20, 2024
shared/AppInsightsCore/Tests/Unit/src/ApplicationInsightsCore.Tests.ts
Outdated
Show resolved
Hide resolved
MSNev
commented
Mar 20, 2024
|
|
||
| export class GlobalTestHooks { | ||
|
|
||
| public registerTests() { |
There was a problem hiding this comment.
This is using a "hack" of our current test infrastructure to "set" some global configuration that will affect "ALL" tests that follow the initialization. (which is why this was added as the "first" item of every tests bundle.
Of note, is that IF any test also changes / sets / calls the test hook it will "replace" and invalidate this setting (as this is currently a single value, not a list of callbacks)
There was a problem hiding this comment.
They also needed to be created / added here as the "common" test infrastructure does not have access to the main "Application Insights" code to be able to add code specific "hooks"
Karlie-777
approved these changes
Mar 20, 2024
siyuniu-ms
approved these changes
Mar 20, 2024
…ting #2311 - Rework Asynchronous notification handling
MSNev
force-pushed
the
MSNev/MainNotifications
branch
from
d8f1728
to
df29fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.