Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the SCOM insights workbook and removing the overview workbook #2664

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ssachin872
Copy link
Contributor

@ssachin872 ssachin872 commented May 20, 2024

PR Checklist

  • Explain your changes, so people looking at the PR know what and why, the code changes are the how.
    These changes are to add insights workbook for SCOM managed instance
  • Validate your changes using one or more of the testing methods.
    Verified by uploading package to a storage blob

If adding or updating templates:

  • post a screenshot of templates and/or gallery changes
    image

image

image

Done

  • ensure your template has a corresponding gallery entry in the gallery folder
    Done
  • If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals
    Done
  • ensure all steps have meaningful names
    Done
  • ensure all parameters and grid columns have display names set so they can be localized
    Done
  • ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)
    Done
  • ensure that steps names are unique or they will fail PR validation (step names are used for localization)
    Done
  • grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR
    validation

    Done
  • remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation
    Done

@ssachin872 ssachin872 requested a review from a team as a code owner May 20, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant