Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ADAL SignIn workbook with additional feilds and restructuing #2641

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

negoe
Copy link

@negoe negoe commented Apr 26, 2024

  1. Added Service Principal SignIn logs to offer customers more detailed insights.
  2. Introduced Client IP information to assist customers in better investigating the sources of authentication requests.
  3. Restructured the components and relocated the all-data table to the top, providing a comprehensive overview first, followed by a more filtered view based on locations.

Feature 2918814 Update SignIn WorkBook with ADAL sign Ins

@negoe
Copy link
Author

negoe commented Apr 29, 2024

Feature 2918814: Update SignIn WorkBook with SP Sign Ins

@negoe negoe marked this pull request as ready for review May 7, 2024 17:13
@negoe negoe requested a review from a team as a code owner May 7, 2024 17:13
@negoe negoe marked this pull request as draft May 10, 2024 04:01
@negoe negoe marked this pull request as ready for review May 13, 2024 18:32
@negoe negoe self-assigned this May 13, 2024
Copy link

@YanyanJu1030 YanyanJu1030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signed off

Copy link
Contributor

@dhanyahk dhanyahk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links in the workbook just opens up a pane with the same field and no additional details. Avoid links unless you have additional information you want to show when the link is clicked.

I am signing off on this based on the fact that another IDX member from Engg signed off as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants