Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding backup gallery file view #2538

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

naba6327108
Copy link
Contributor

Screenshot 2023-11-06 113923

PR Checklist

  • Explain your changes, so people looking at the PR know what and why, the code changes are the how.
  • Validate your changes using one or more of the testing methods.

If adding or updating templates:

  • post a screenshot of templates and/or gallery changes
  • ensure your template has a corresponding gallery entry in the gallery folder
  • If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals
  • ensure all steps have meaningful names
  • ensure all parameters and grid columns have display names set so they can be localized
  • ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)
  • ensure that steps names are unique or they will fail PR validation (step names are used for localization)
  • grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validation
  • remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation

@naba6327108 naba6327108 requested a review from a team as a code owner January 18, 2024 11:00
"author": "Microsoft",
"description": "Gain visibility into backup job statistics, consumption trends and optimization opportunities across your Recovery Services vaults and Backup vaults",
"name": "Backup Reports (consolidated)"
"isPreview": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is invalid json, every line with isPreview is missing the comma at the end of the previous line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants