Downgrade core processor dependency scope #96
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
Just want to point out that this seems like a workaround to a bug in Maven to me 🤷♂️ Do note that validation is only one processor and this kind of fix would have to be applied to all annotation processors across all modules (openapi, data, serde, spring etc.) It also means that if you define a dependency on only the processor it will not transitively pull in its required dependencies and you will likely get weird compilation errors. |
It certainly is, acknowledged and in progress. But meanwhile, this is our only choice.
Correct. I'll come across them as needed.
Incorrect. This PR only changes the exposure of Micronaut Core processor. Any other dependency will be pulled in. Like I said, regardless of the Maven bug, there is no reason for the Validation processor to expose the Core processor. |
This PR changes the scope of the Micronaut Core annotation processor from
apitocompileOnly.Now that Validation is separated from Core, exposing the Core processor as an API dependency is causing trouble in Maven projects. If the Core version defined in the project and the one exposed by Validation are different, both will end up in the annotation processor classpath. This is because Maven doesn't enforce dependency management rules in annotation processor classpaths, as explained in MCOMPILER-391.
Once apache/maven-compiler-plugin#180 is merged and released, we may see a solution for this issue, but regardless of that, it is incorrect to expose a Core processor (which is already in the processor classpath for all Micronaut applications).