Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration option to destroy UCP pool #1551

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

radovanradic
Copy link
Contributor

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
*/
@ConfigurationProperties(PREFIX)
@Requires(property = PREFIX)
public record OracleUcpConfiguration(@Nullable Boolean destroyOnReload) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there might be other oracle.ucp.* properties to set and we can use this for that purpose and looks to me it's better to keep separated from the ucp-manager.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rescheduled this to 4.9

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@sdelamo sdelamo requested a review from graemerocher March 5, 2025 10:05
@radovanradic radovanradic merged commit f40195a into 6.1.x Mar 6, 2025
45 of 46 checks passed
@radovanradic radovanradic deleted the ucp-destroy-on-reload branch March 6, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants