return bad request if IllegalArgumentException #199
Merged
+70
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
requested changes
Oct 29, 2024
| } | ||
| } catch (IllegalArgumentException e) { | ||
| return Flux.error(new HttpStatusException(HttpStatus.BAD_REQUEST, e.getMessage())); |
There was a problem hiding this comment.
may as well just throw the exception
There was a problem hiding this comment.
that is what the user complains about.
@mancze :
Micronaut server should not return 500 Internal Server Error in case of malformed session cookie in the request. It is incorrectly formatted request which should be categorized as 4xx.
He thinks we should not return a 500 for a IllegalArgumentException and we should return a 400 or maybe a 422.
I think we should fix this in core with a new ExceptionHandler for IllegalArgumentException. What do you think @dstepanov ?
…ter.java Co-authored-by: Graeme Rocher <graeme.rocher@oracle.com>
graemerocher
approved these changes
Oct 30, 2024
…ssionFilter.java" This reverts commit c56432f.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #198
I am not sure if we should fix this in
micronaut-session. I lean towards creating anExeptionHandlerinMicronaut-coreforIllegalArgumentException. thoughts?