Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if no Micronaut Environment add default as profile #664

Merged
merged 3 commits into from
Jan 24, 2025
Merged

if no Micronaut Environment add default as profile #664

merged 3 commits into from
Jan 24, 2025
+10 −3

Conversation

AndreyIvanovDev
Copy link
Contributor

@AndreyIvanovDev AndreyIvanovDev commented Nov 27, 2024 •
edited by sdelamo
Loading

Close #652

  1. add introspected
  2. add setter for properySources
  3. add default profile
    100% working option

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

sdelamo
sdelamo requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to sign the CLA

sdelamo
sdelamo requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It misses tests

@sdelamo sdelamo added the type: bug Something isn't working label Jan 2, 2025
@AndreyIvanovDev AndreyIvanovDev force-pushed the bugfix/issue-652 branch 2 times, most recently from a442716 to 2fc5e8e Compare January 3, 2025 10:36
@sdelamo
Copy link
Contributor

sdelamo commented Jan 10, 2025

@AndreyIvanovDev can you sign the CLA?

@sdelamo
Copy link
Contributor

sdelamo commented Jan 10, 2025

I created a PR which partially covers this PR #684

@AndreyIvanovDev
issues-652: see micronaut-projects#652

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
0594ea1 
1) add introspected
2) add setter for properySources
3) add default profile
100% working option
@graemerocher graemerocher requested a review from sdelamo January 14, 2025 19:34
@sdelamo
Merge branch '4.6.x' into pr/664

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
027a08a
@sdelamo sdelamo changed the title issues-652: see https://github.com/micronaut-projects/micronaut-disco… if no Micronaut Environment add default as profile Jan 24, 2025
@sdelamo
fix merge

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
56378e1
@sdelamo sdelamo merged commit 6e72e34 into micronaut-projects:4.6.x Jan 24, 2025
1 check passed
sdelamo pushed a commit that referenced this pull request Jan 24, 2025
@AndreyIvanovDev @sdelamo
if no Micronaut Environment add default as profile (#664)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
386af0c 
add javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
4.8.0 Release
Status: Done
Milestone
No milestone
3 participants
@AndreyIvanovDev @CLAassistant @sdelamo