Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for alias selection in the keystore #11503

Conversation

viniciusxyz
Copy link
Contributor

@viniciusxyz viniciusxyz commented Jan 13, 2025

The approach used is very simple, the content of the alias is extracted and a new object representing a keystore is created only with that alias, this way it is possible to load only the desired alias and no more errors occur when we have multiple aliases in the keystore each with a password

Related issue #11430

@viniciusxyz viniciusxyz changed the title Added support for alias selection in the keystore - Related issue #11430 Added support for alias selection in the keystore Jan 13, 2025
@viniciusxyz viniciusxyz force-pushed the feature/support-for-alias-selection-in-keystore branch 2 times, most recently from 2a8e576 to 5a3bbb4 Compare January 14, 2025 12:00
@sdelamo sdelamo requested a review from yawkat January 15, 2025 08:29
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

@viniciusxyz
Copy link
Contributor Author

Could you add a test?

for sure, I will do it today.

@viniciusxyz viniciusxyz force-pushed the feature/support-for-alias-selection-in-keystore branch 3 times, most recently from 899825e to 41c3d3d Compare January 15, 2025 20:33
@viniciusxyz viniciusxyz force-pushed the feature/support-for-alias-selection-in-keystore branch from 41c3d3d to 8fade6d Compare January 16, 2025 10:53
@graemerocher graemerocher requested a review from sdelamo January 16, 2025 12:15
@graemerocher graemerocher added the type: improvement A minor improvement to an existing feature label Jan 16, 2025
@graemerocher graemerocher merged commit 93b612e into micronaut-projects:4.8.x Jan 27, 2025
16 checks passed
@graemerocher
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants