Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sourcegen bytecode generator to generate internal metadata #11407

Merged
merged 14 commits into from
Jan 9, 2025

Conversation

dstepanov
Copy link
Contributor

The PR rewrites all the class writers (except the evaluated expressions writer) to use a new bytecode generator from Micronaut Sourcegen.

I haven't done any major refactoring. Some classes like BeanDefnitionWriter is too big and need some refactoring

@dstepanov dstepanov added the type: improvement A minor improvement to an existing feature label Dec 4, 2024
@dstepanov dstepanov added this to the 4.8.0 milestone Dec 4, 2024

Verified

This commit was signed with the committer’s verified signature.
edgarrmondragon Edgar Ramírez Mondragón

Verified

This commit was signed with the committer’s verified signature.
edgarrmondragon Edgar Ramírez Mondragón
CR

Verified

This commit was signed with the committer’s verified signature.
edgarrmondragon Edgar Ramírez Mondragón
CR

Verified

This commit was signed with the committer’s verified signature.
edgarrmondragon Edgar Ramírez Mondragón
CR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@graemerocher graemerocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to make sure that we retain that the generated byte code is synthetic

CR
CR
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
5 New Bugs (required ≤ 0)
7 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dstepanov dstepanov merged commit f79f8b6 into 4.8.x Jan 9, 2025
21 of 22 checks passed
@dstepanov dstepanov deleted the sourcegen branch January 9, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants