feat: allow endpoint path customization #11369
Merged
+72
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, [kamal](https://kamal-deploy.org) expects health check to be in /up
sdelamo
commented
Nov 22, 2024
.../src/main/java/io/micronaut/management/endpoint/processors/AbstractEndpointRouteBuilder.java
Outdated
Show resolved
Hide resolved
…essors/AbstractEndpointRouteBuilder.java
yawkat
reviewed
Nov 22, 2024
management/src/main/java/io/micronaut/management/endpoint/EndpointConfiguration.java
Outdated
Show resolved
Hide resolved
yawkat
approved these changes
Nov 22, 2024
graemerocher
requested changes
Nov 22, 2024
management/src/main/java/io/micronaut/management/endpoint/EndpointConfiguration.java
Outdated
Show resolved
Hide resolved
| @@ -132,6 +134,12 @@ protected Optional<String> resolveActiveEndPointId(Class<?> declaringType) { | |||
| BeanDefinition<?> beanDefinition = opt.get(); | |||
| if (beanDefinition.hasStereotype(Endpoint.class)) { | |||
| String id = beanDefinition.stringValue(Endpoint.class).orElse(null); | |||
| if (beanContext.containsBean(EndpointConfiguration.class, Qualifiers.byName(id))) { | |||
There was a problem hiding this comment.
probably better to use beanContext.getProvider and then isPresent() followed by get()
There was a problem hiding this comment.
why is better? Is it more performant to retrieve a bean via the BeanProvider API vs the BeanContext API?
There was a problem hiding this comment.
I changed to use BeanProvider here 85076fe
graemerocher
approved these changes
Nov 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, kamal expects health check to be in /up