Optimizations in reactor <-> ExecutionFlow transformations #11297
+384
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yawkat
commented
Nov 1, 2024
yawkat
commented
- In toPublisher, return a specialized FlowAsMono that (a) directly extends Mono so does not need a reactor wrapper and (b) supports SYNC fusion so that when the flow completes after the toPublisher call but before subscribe, we can take advantage of reactor fusion operations.
- Introduce a new method fromPublisherEager that can unwrap FluxAsMono directly (to short-circuit the direct ExecutionFlow->Publisher->ExecutionFlow transform) but can also transform Monos that complete immediately (e.g. Mono.just(…).map(…)) directly to ImperativeExecutionFlow.
Also adds cancellation support to ExecutionFlow.
Implement "proper" context propagation in the client to get rid of the old ClientServerContextFilter. Because context propagation uses its own key for the reactor context instead of ServerRequestContext.KEY, I've deprecated ServerRequestContext.KEY and added a more general API that can use the propagated context from the ContextView.
- In toPublisher, return a specialized FlowAsMono that (a) directly extends Mono so does not need a reactor wrapper and (b) supports SYNC fusion so that when the flow completes after the toPublisher call but before subscribe, we can take advantage of reactor fusion operations. - Introduce a new method fromPublisherEager that can unwrap FluxAsMono directly (to short-circuit the direct ExecutionFlow->Publisher->ExecutionFlow transform) but can also transform Monos that complete immediately (e.g. Mono.just(…).map(…)) directly to ImperativeExecutionFlow.
graemerocher
approved these changes
Nov 11, 2024
http/src/main/java/io/micronaut/http/reactive/execution/ReactiveExecutionFlow.java
Outdated
Show resolved
Hide resolved
|
Can you please merge after #11317 |
|
|
please address the sonar blocking issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.