Remove context propagation filter #11294
Merged
+79
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds cancellation support to ExecutionFlow.
Implement "proper" context propagation in the client to get rid of the old ClientServerContextFilter. Because context propagation uses its own key for the reactor context instead of ServerRequestContext.KEY, I've deprecated ServerRequestContext.KEY and added a more general API that can use the propagated context from the ContextView.
graemerocher
approved these changes
Oct 31, 2024
| * @return The request context if it is present | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public static <T> Optional<HttpRequest<T>> currentRequest(ContextView context) { |
There was a problem hiding this comment.
add @since and nullability annotation to the parameter
dstepanov
approved these changes
Nov 5, 2024
# Conflicts: # http-client/src/main/java/io/micronaut/http/client/netty/DefaultHttpClient.java
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement "proper" context propagation in the client to get rid of the old ClientServerContextFilter.
Because context propagation uses its own key for the reactor context instead of ServerRequestContext.KEY, I've deprecated ServerRequestContext.KEY and added a more general API that can use the propagated context from the ContextView.