Add ByteBody.move #11280
Merged
Add ByteBody.move #11280
+126
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is a primary operation that transfers ownership. In particular this means it can convert a ByteBody (where the current code does not have exclusive ownership) to a CloseableByteBody (where it does). The method cannot be implemented using existing methods. But that's okay since ByteBody is experimental, not implemented outside core (anymore), and this method is not used by core.
|
dstepanov
approved these changes
Oct 29, 2024
graemerocher
approved these changes
Oct 29, 2024
yawkat
added a commit
that referenced
this pull request
Nov 6, 2024
* Add ByteBody.move (#11280) * Migrate netty HttpClient to ExecutionFlow Also adds cancellation support to ExecutionFlow. * review * fix double cancel --------- Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is a primary operation that transfers ownership. In particular this means it can convert a ByteBody (where the current code does not have exclusive ownership) to a CloseableByteBody (where it does).
The method cannot be implemented using existing methods. But that's okay since ByteBody is experimental, not implemented outside core (anymore), and this method is not used by core.