JDK RawHttpClient #11259
Merged
JDK RawHttpClient #11259
+1,546
−443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft because I still need to add tests
# Conflicts: # http-client-core/src/main/java/io/micronaut/http/client/RawHttpClientFactory.java # http-client/src/main/java/io/micronaut/http/client/netty/RawHttpRequestWrapper.java # http/src/main/java/io/micronaut/http/MutableHttpRequestWrapper.java
graemerocher
requested changes
Oct 17, 2024
http-client-jdk/src/main/java/io/micronaut/http/client/jdk/DefaultJdkHttpClientRegistry.java
Outdated
Show resolved
Hide resolved
http-client-jdk/src/main/java/io/micronaut/http/client/jdk/JdkRawHttpClient.java
Outdated
Show resolved
Hide resolved
http-client-jdk/src/main/java/io/micronaut/http/client/jdk/JdkRawHttpClient.java
Outdated
Show resolved
Hide resolved
http-client-jdk/src/main/java/io/micronaut/http/client/jdk/ReactiveByteBufferByteBody.java
Outdated
Show resolved
Hide resolved
http-client-jdk/src/main/java/io/micronaut/http/client/jdk/ReactiveByteBufferByteBody.java
Outdated
Show resolved
Hide resolved
http-client-jdk/src/main/java/io/micronaut/http/client/jdk/ReactiveByteBufferByteBody.java
Show resolved
Hide resolved
http-netty/src/main/java/io/micronaut/http/netty/body/ByteBufConsumer.java
Show resolved
Hide resolved
http-netty/src/main/java/io/micronaut/http/netty/body/ByteBufConsumer.java
Outdated
Show resolved
Hide resolved
http/src/main/java/io/micronaut/http/MutableHttpRequestWrapper.java
Outdated
Show resolved
Hide resolved
|
I think the sonar coverage stats are not including the TCK |
|
graemerocher
approved these changes
Oct 26, 2024
dstepanov
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a RawHttpClient implementation in the JDK client. In principle it's not so complicated, but to actually be useful, it needed a streaming reactive ByteBody implementation, which is complicated to implement.
To implement this, I've refactored the StreamingNettyByteBody implementation into a "generic" implementation that is implemented both for the netty ByteBuf/EventLoop approach, and a more traditional ByteBuffer/lock approach for the jdk client.
In particular the SharedBuffer refactor is fairly complicated. While the general code remains unchanged, making it work for different buffer types and concurrency models is still a bit complicated.