Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MediaTypeCodec and use Message Body Writer / Reader API for clients #11121

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

dstepanov
Copy link
Contributor

I tested it by disabling all codecs, and the tests passed.

Right now, we still don't use the message body API for functions. We should convert other modules: servlet, Oracle Cloud, Azure, and GCP.

* @since 4.7
*/
default MutableHttpRequest<B> toMutableRequest() {
if (this instanceof MutableHttpRequest<B> mutableHttpRequest) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just override the method in MutableHttpRequest instead of using this instanceof

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did also override it

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 70%)
B Maintainability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@dstepanov dstepanov merged commit 06ca036 into 4.6.x Aug 28, 2024
16 of 17 checks passed
@dstepanov dstepanov deleted the codecs branch August 28, 2024 07:57
altro3 pushed a commit to altro3/micronaut-core that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants