Fix stream backpressure when compressing #11115
Merged
+53
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compression is on, writeCompressing will immediately advance the buffer position, so `buf.readableBytes()` would be 0 and backpressure would not be relieved properly. Fixes #11114
|
dstepanov
approved these changes
Aug 26, 2024
| @@ -58,6 +59,7 @@ public final class InputStreamBodyWriter extends AbstractFileBodyWriter implemen | |||
|
|
|||
| @Override | |||
| public void writeTo(HttpRequest<?> request, MutableHttpResponse<InputStream> outgoingResponse, Argument<InputStream> type, MediaType mediaType, InputStream object, NettyWriteContext nettyContext) throws CodecException { | |||
| outgoingResponse.getHeaders().setIfMissing(HttpHeaderNames.CONTENT_TYPE, mediaType); | |||
There was a problem hiding this comment.
Check if mediaType is not null
altro3
pushed a commit
to altro3/micronaut-core
that referenced
this pull request
Aug 31, 2024
When compression is on, writeCompressing will immediately advance the buffer position, so `buf.readableBytes()` would be 0 and backpressure would not be relieved properly. Fixes micronaut-projects#11114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compression is on, writeCompressing will immediately advance the buffer position, so
buf.readableBytes()would be 0 and backpressure would not be relieved properly.Fixes #11114