Add getDuration method to FinishedSpan #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
micrometer-tracing/src/main/java/io/micrometer/tracing/exporter/FinishedSpan.java
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
marcingrzejszczak
approved these changes
May 19, 2023
jonatan-ivanov
requested changes
May 19, 2023
micrometer-tracing/src/main/java/io/micrometer/tracing/exporter/FinishedSpan.java
Show resolved
Hide resolved
micrometer-tracing/src/main/java/io/micrometer/tracing/exporter/FinishedSpan.java
Show resolved
Hide resolved
jonatan-ivanov
changed the title
| @@ -60,6 +62,14 @@ public interface FinishedSpan { | |||
| */ | |||
| Instant getEndTimestamp(); | |||
|
|
|||
| /** | |||
| * @return span's duration | |||
There was a problem hiding this comment.
MissingSummary: A summary line is required on public/protected Javadocs.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
jonatan-ivanov
approved these changes
May 25, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.