No-op implementations for Propagator, Setter, and Getter #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
micrometer-tracing/src/main/java/io/micrometer/tracing/propagation/Propagator.java
Outdated
Show resolved
Hide resolved
marcingrzejszczak
approved these changes
Nov 12, 2022
jonatan-ivanov
approved these changes
Nov 12, 2022
ttddyy
force-pushed
the
noop-propagator
branch
from
f418166
to
e98ffb7
Compare
Add no-op implementations for Propagator and its Setter and Getter.
ttddyy
force-pushed
the
noop-propagator
branch
from
e98ffb7
to
d1f882c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing a custom
Propagating[Sender|Receiver]TracingObservationHandler, if it doesn't require propagation, such as database access, I found writing noop implementations by myself. Instead, it should be provided from library.