Fix flakiness in JettyClientMetricsWithObservationTest.activeTimer() #5894
+29
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the following failure locally:
It could be reproducible with
@RepeatedTest(100)
locally, and the Develocity Build Scan also flags it as a flaky one.Looking into its code, there seems to be a race condition, but I couldn't find a clean way to fix it.
This PR attempts to fix its flakiness even though it's still relying on timing.