Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TimedAspectTest.pjpFunctionThrows() #5889

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Feb 4, 2025

This PR enables the TimedAspectTest.pjpFunctionThrows() as it seems to have been missed accidentally.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Johnny Lim <izeye@naver.com>
@izeye
Copy link
Contributor Author

izeye commented Feb 4, 2025

The "build" has failed with the following failure:

PushMeterRegistryTest > closeRespectsInterrupt() FAILED
    org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.micrometer.core.instrument.push.PushMeterRegistryTest null within 10 milliseconds.
        at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
        at app//org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
        at app//org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
        at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
        at app//org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
        at app//io.micrometer.core.instrument.push.PushMeterRegistryTest.closeRespectsInterrupt(PushMeterRegistryTest.java:248)

        Caused by:
        java.util.concurrent.TimeoutException
            at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:204)
            at org.awaitility.core.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:101)
            at org.awaitility.core.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:81)
            at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:103)
            ... 5 more

I created #5890 to try to mitigate its flakiness.

See https://app.circleci.com/pipelines/github/micrometer-metrics/micrometer/8379/workflows/ddfcbe08-388d-4b99-a0d0-abaacca96fb5/jobs/42323

@shakuzen shakuzen added the type: task A general task label Feb 5, 2025
@shakuzen shakuzen added this to the 1.13.11 milestone Feb 5, 2025
@shakuzen shakuzen merged commit f129c66 into micrometer-metrics:1.13.x Feb 5, 2025
7 of 8 checks passed
@izeye izeye deleted the enable branch February 5, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants