Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DefaultHttpClientObservationConvention#INSTANCE final #4770

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Make DefaultHttpClientObservationConvention#INSTANCE final #4770

merged 1 commit into from
Feb 27, 2024

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Feb 25, 2024

This PR makes DefaultHttpClientObservationConvention#INSTANCE final as being non-final seems to be accidental.

@shakuzen shakuzen added type: task A general task release notes Noteworthy change to call out in the release notes labels Feb 27, 2024
@shakuzen shakuzen added this to the 1.11.10 milestone Feb 27, 2024
@shakuzen shakuzen added the module: micrometer-core An issue that is related to our core module label Feb 27, 2024
@shakuzen shakuzen merged commit a228c2a into micrometer-metrics:1.11.x Feb 27, 2024
6 checks passed
@izeye izeye deleted the final-20240226 branch February 27, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module: micrometer-core An issue that is related to our core module release notes Noteworthy change to call out in the release notes type: task A general task
Projects
None yet
Milestone
1.11.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izeye @shakuzen