Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL decode headers from environment variables in OtlpConfig #4595

Merged
merged 3 commits into from Jan 31, 2024
Merged

URL decode headers from environment variables in OtlpConfig #4595

merged 3 commits into from Jan 31, 2024

Conversation

zeitlinger
Copy link
Contributor

@zeitlinger zeitlinger commented Jan 18, 2024 •
edited

@shakuzen shakuzen added the registry: otlp OpenTelemetry Protocol (OTLP) registry-related label Jan 25, 2024
@shakuzen shakuzen changed the title header values are be expected to be W3C baggage encoded URL decode headers from environment variables in OtlpConfig Jan 25, 2024
shakuzen
shakuzen approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like it's a bug we didn't do this before. If so, we should include it in maintenance releases. What do you think?

...tions/micrometer-registry-otlp/src/test/java/io/micrometer/registry/otlp/OtlpConfigTest.java Outdated Show resolved Hide resolved
@zeitlinger
Copy link
Contributor Author

It sounds like it's a bug we didn't do this before. If so, we should include it in maintenance releases. What do you think?

I agree - see open-telemetry/opentelemetry-specification#3832 (comment)

@shakuzen shakuzen added the bug A general bug label Jan 31, 2024
@shakuzen shakuzen added this to the 1.11.9 milestone Jan 31, 2024
@shakuzen shakuzen changed the base branch from main to 1.11.x January 31, 2024 04:07
@shakuzen
Copy link
Member

Thanks. I've rebased the pull request on the 1.11.x branch. We'll merge forward from there to include it in our upcoming round of maintenance releases.

@shakuzen shakuzen merged commit 33bb267 into micrometer-metrics:1.11.x Jan 31, 2024
5 checks passed
shakuzen added a commit that referenced this pull request Jan 31, 2024
@shakuzen
Polish
3a6923d 
Polish gh-4595
@zeitlinger zeitlinger deleted the otlp-header-encoding branch February 2, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcingrzejszczak marcingrzejszczak marcingrzejszczak approved these changes

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
bug A general bug registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Projects
None yet
Milestone
1.11.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zeitlinger @shakuzen @marcingrzejszczak