[Dynatrace v2] Only serialize metadata when set on the meter #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
added a commit
that referenced
this pull request
Oct 21, 2023
gh-4006 added support for metrics metadata (unit and description) in the Dynatrace Exporter. The exporter always added the metadata even if unit or description were not set. After these changes, the exporter should not attempt to add metadata if no unit or description was set on the metric. See gh-4247 See gh-3979 See gh-4006 Co-authored-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Bugfix)
In #4006, we added support for metrics metadata (unit/description). While working on something unrelated, we realized that the exporter will try to serialize metadata to the Dynatrace transport format. When no metadata is set on the meter (e.g. custom metrics introduced by users) the serialization library will log a warning stating that metadata serialization had been called without setting data. This can lead to many log lines.
Since it is perfectly fine to create meters without metadata, the exporter should not attempt to create metadata lines if no metadata was set on the metric.