Move Jakarta JMS instrumentation to micrometer-jakarta9 #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new module micrometer-jakarta10 and moves the previously merged JMS instrumentation there. The reason for this is that we tend to try to support a range of versions when possible for our users, and if Jakarta makes breaking changes in the future, we would not be able to support that in a single module (such as micrometer-core, or micrometer-jakarta) unless the new Jakarta artifacts used different coordinates.
shakuzen
force-pushed
the
jakarta10-module
branch
from
3cf4d2e
to
814a03b
Compare
shakuzen
added a commit
that referenced
this pull request
Oct 10, 2023
There is no strong reason to baseline on the higher 10. Setting the baseline to 9 will allow more people to utilize this module. See gh-4201
shakuzen
changed the title
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Nov 1, 2023
jonatan-ivanov
pushed a commit
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new module micrometer-jakarta9 and moves the previously merged JMS instrumentation there. The reason for this is that we tend to try to support a range of versions when possible for our users, and if Jakarta makes breaking changes in the future, we would not be able to support that in a single module (such as micrometer-core, or micrometer-jakarta) unless the new Jakarta artifacts used different coordinates.
The Jakarta JMS instrumentation was introduced in #4007. This moves it, unchanged, to the new module for the above mentioned reason.
This is a portion of the changes that were proposed in #3989.