Introduce HttpJakartaServletRequestTags #3923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
approved these changes
Jun 22, 2023
Prior to this commit, `HttpRequestTags` would provide Tags for both "javax.*" and "jakarta.*" variants of `HttpServletRequest`. While the `HttpServletRequestTagsProvider` and `HttpJakartaServletRequestTagsProvider` are separate interfaces, they both use `HttpRequestTags` and import all types exposed on its methods. It is strongly advised not to import both "javax.*" and "jakarta.*" variants in a typical application and the current arrangement prevents this best practice. This commit deprecates Jakarta methods variants in `HttpRequestTags` and moves them to `HttpJakartaServletRequestTags`. This allows a clean dependency setup for Jakarta apps and a migration path for all in the meantime. Closes micrometer-metricsgh-3804
|
Closed with 70e328f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
HttpRequestTagswould provide Tags for bothjavax.*andjakarta.*variants ofHttpServletRequest. While theHttpServletRequestTagsProviderandHttpJakartaServletRequestTagsProviderare separate interfaces, theyboth use
HttpRequestTagsand import all types exposed on its methods.It is strongly advised not to import both
javax.*andjakarta.*variants in a typical application and the current arrangement prevents
this best practice.
This commit deprecates Jakarta methods variants in
HttpRequestTagsandmoves them to
HttpJakartaServletRequestTags. This allows a cleandependency setup for Jakarta apps and a migration path for all in the
meantime.
Closes gh-3804